⭐️ add scanner client #270
Conversation
chris-rock
force-pushed
the
chris-rock/scanner-client
branch
from
d2e8832 to
4b03d08
Compare
pkg/scanner/scanner.go
Outdated
| "net/http" | ||
| "time" | ||
|
|
||
| "github.com/pkg/errors" |
There was a problem hiding this comment.
could we get rid of this dependency? The repo has been archived and is not maintained. There are other projects that are also actively working on using whatever is available in the standard errors package and rewrite whatever is not (e.g. Wrap doesn't exist in the standard pkg).
Some references:
prometheus-operator/prometheus-operator#4682
thanos-io/thanos#5176
There was a problem hiding this comment.
perhaps it's good to check if we have this dependency in any of the other projects as well
There was a problem hiding this comment.
yeah, we can remove that, that was an auto-import
|
Thank you for the improvements @joelddiaz, I cannot self-approve, so you have to approve :-) |
pkg/scanner/scanner_test.go
Outdated
| result := &ScanResult{ | ||
| Ok: true, | ||
| WorstScore: &Score{ | ||
| Type: uint32(2), |
There was a problem hiding this comment.
What's a type 2? Maybe constify that to make the variable name self-documenting.
joelddiaz
force-pushed
the
chris-rock/scanner-client
branch
2 times, most recently
from
c5110d8 to
613f764
Compare
|
@imilchev this should be good for a review |
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
Signed-off-by: Joel Diaz <joel@mondoo.com>
clarify that a '2' is what comes back from a valid scan result Signed-off-by: Joel Diaz <joel@mondoo.com>
joelddiaz
force-pushed
the
chris-rock/scanner-client
branch
from
613f764 to
57f005b
Compare
Signed-off-by: Joel Diaz <joel@mondoo.com>
add a simple http client for the mondoo scanner