Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-33244: spark compatibility updates #180

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

ccho-mongodb
Copy link
Contributor

@ccho-mongodb ccho-mongodb commented Oct 2, 2023

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-33244
Staging -

Landing page
Getting started

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?

Copy link
Contributor

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + 1 suggestion

Comment on lines 7 to 9
- MongoDB (version 4.0 or later)

- Spark version 3.1 or later.
- Spark version 3.1 through 3.2.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: To keep these two lines consistent, either:

  • Put versions in parens on the Spark line
  • Remove versions from parens on the MongoDB line

@ccho-mongodb ccho-mongodb merged commit d9bf0a2 into mongodb:master Oct 2, 2023
2 checks passed
@ccho-mongodb ccho-mongodb deleted the DOCSP-33244-spark-compat branch October 2, 2023 15:04
ccho-mongodb pushed a commit that referenced this pull request Oct 2, 2023
* DOCSP-33244: spark compatibility updates

(cherry picked from commit d9bf0a2)
ccho-mongodb pushed a commit that referenced this pull request Oct 2, 2023
* DOCSP-33244: spark compatibility updates

(cherry picked from commit d9bf0a2)
ccho-mongodb pushed a commit that referenced this pull request Oct 2, 2023
* DOCSP-33244: spark compatibility updates

(cherry picked from commit d9bf0a2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants