Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-44252 - EOL v1.2 and v1.3 What's New #66

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

mongoKart
Copy link
Collaborator

@mongoKart mongoKart commented Oct 22, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-44252
Staging: https://deploy-preview-66--docs-visual-studio-extension.netlify.app/whats-new/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for docs-visual-studio-extension ready!

Name Link
🔨 Latest commit eab3b5e
🔍 Latest deploy log https://app.netlify.com/sites/docs-visual-studio-extension/deploys/671905979ed57500088a4004
😎 Deploy Preview https://deploy-preview-66--docs-visual-studio-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@mcmorisi mcmorisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mongoKart mongoKart merged commit 4a273da into mongodb:master Oct 23, 2024
8 checks passed
@mongoKart mongoKart deleted the docsp-44252-eol-analyzer-notes branch October 23, 2024 14:19
Copy link

The backport to v1.4 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v1.4 v1.4
# Navigate to the new working tree
cd .worktrees/backport-v1.4
# Create a new branch
git switch --create backport-66-to-v1.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4a273dae36626182028824e1eac19db1b82fd18d
# Push it to GitHub
git push --set-upstream origin backport-66-to-v1.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v1.4

Then, create a pull request where the base branch is v1.4 and the compare/head branch is backport-66-to-v1.4.

github-actions bot pushed a commit that referenced this pull request Oct 23, 2024
mongoKart added a commit that referenced this pull request Oct 23, 2024
(cherry picked from commit 4a273da)

Co-authored-by: Mike Woofter <108414937+mongoKart@users.noreply.github.com>
mongoKart added a commit that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants