PHPC-1739 Move from travis-ci to GitHub Actions #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
phpc-1739
branch
2 times, most recently
from
49bbd03 to
986cb7f
Compare
jmikola
reviewed
Feb 17, 2021
.evergreen/orchestration/configs/replica_sets/replicaset-old.json
Outdated
Show resolved
Hide resolved
jmikola
reviewed
Feb 19, 2021
This drops the legacy VM environment and remnants of the travis-ci config
This did not have the expected effect of preventing diff output for tests that expect failures, so it can be reverted.
Since mongo-orchestration will always bring its own certificates, we need to set the correct SSL certificate directory for our tests. This is skipped on GitHub Actions as we don't test SSL builds there (yet). If SSL_DIR was not set, tests requiring SSL will be skipped.
jmikola
reviewed
Feb 23, 2021
CONTRIBUTING.md
Outdated
|
|
||
| ``` | ||
| make test-bootstrap | ||
| MONGO_ORCHESTRATION_URI=http://some-host:1234/v1 make test |
There was a problem hiding this comment.
nit: either use example.com (what it's intended for) for localhost. In practice, I can't imagine MO would run somewhere other than localhost. This is generally just needed if the the port is changed. I think localhost:1234 would be fine.
jmikola
reviewed
Feb 23, 2021
tests/utils/skipif.php
Outdated
| function skip_if_no_ssl_dir() | ||
| { | ||
| $sslDir = getenv('SSL_DIR'); | ||
| $sslDir !== false or exit('skip SSL_DIR environment not set'); |
There was a problem hiding this comment.
nit: "environment variable" or omit "environment" entirely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPC-1739
This PR drops travis-ci.yml and adds GitHub Actions workflows for tests and clang-format. Tests currently only run on PHP 7.4 and 8.0, with the rest being tested on Evergreen.
Due to this change, we also had to remove custom mo configs, as the GitHub action leverages drivers-evergreen-tools. Tests are now stable both on GitHub Actions and Evergreen, with only selected config files needing overriding. Due to this, this PR includes cleanup scheduled in PHPC-1242, but I can extract this to a separate PR if necessary.
Since this PR targets v1.9 which isn't tested by Evergreen, here's a patch build running ALL tasks and variants: https://spruce.mongodb.com/version/6026605bc9ec4448427d4f1f/tasks