Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layout): changes in the header, remove unnecessary attributes (@Mineclinee) #6096

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Mineclinee
Copy link

Description

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #

  • Changing the nesting of the div tag in the header from div to span
    image
    image
  • Removing an unnecessary empty tag in the header (added a related css rule to change the layout breakage)
  • Removing unnecessary attributes in the textarea tag that are an error and are complained about by w3c validator

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@Miodec
Copy link
Member

Miodec commented Dec 6, 2024

Not sure about this, seems like changes for the sake of making a change, instead of fixing an actual issue or making an improvement of some sort. Seems a bit pointless.

Copy link
Contributor

This PR is stale. Please trigger a re-run of the PR check action.

@github-actions github-actions bot added the Stale Has not been updated in a while label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend User interface or web stuff Stale Has not been updated in a while
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants