refactor: move parseJsonWithSchema to utils package (@fehmer) #6109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monkeytypegeorge
added
frontend
fehmer
commented
Dec 12, 2024
There was a problem hiding this comment.
After adding the json.spec.ts file in util package eslint was complaining that the packages/funbox/__test__/tsconfig.json cannot find any files to include.
Instead of supressing this I added this test.
fehmer
commented
Dec 12, 2024
| } | ||
| } | ||
|
|
||
| function prettyErrorMessage(issue: ZodIssue | undefined): string { |
There was a problem hiding this comment.
previously only the error.errors was used to compile the error message. It only contained the validation errors like Expected boolean, received string but not the path so it was unclear what exactly is wrong in the json.
Adding the full path like we do in the error handler on the backend api.
thejus-r
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
funboxpackage because eslint was complaining that there are no tests