Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr: Correct Uzbek okina and more (@Sonotoki-da) #6116

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Sonotoki-da
Copy link

Description

Uzbek words contain incorrect okina characters. I'm an Uzbek who does professional proofreading, and there's an easy fix for this:

  1. After [Oo] and [Gg], ʻ (small six) is added for the correct Oʻzbekiston (Uzbekistan, the country), gʻisht (brick) words.
  2. Every other character can be safely replaced by ʼ (small nine): masʼuliyat (responsibility), aʼlo (good, excellent).

It's not ' (quotes), it's not ` (backticks), and it's definitely not the non-okina characters that the Google folks mistakenly abuse in their Gboard. Only #Oʻzbekiston and #masʼuliyat can be properly hashtagged, because ʻ and ʼ are counted as a part of the words, not as delimiters.

For reference: https://t.me/xatoliklar/855 (Please use a machine translator. It's a public Uzbek Telegram channel dedicated to highlighting the ill-treated Uzbek language)

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Dec 16, 2024
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@Sonotoki-da
Copy link
Author

⚠️ ʻ and ʼ can't be typed without special programs like AHK in Windows, or for example Sway's bindsym for inserting these characters in Linux. I don't know how monkeytype works, but I have a possible solution: just type ' (a quote in your keyboard) for both ʻ and ʼ. But remember, Oʻzbekiston and masʼuliyat are THE ONLY CORRECT WAYS to spell these words

@Miodec
Copy link
Member

Miodec commented Dec 21, 2024

⚠️ ʻ and ʼ can't be typed without special programs like AHK in Windows, or for example Sway's bindsym for inserting these characters in Linux. I don't know how monkeytype works, but I have a possible solution: just type ' (a quote in your keyboard) for both ʻ and ʼ. But remember, Oʻzbekiston and masʼuliyat are THE ONLY CORRECT WAYS to spell these words

Ill add ʻ to the list of interchangable quote characters so that they all can be typed with '.

image

Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@Miodec
Copy link
Member

Miodec commented Dec 22, 2024

1k and 70k have some duplicate words now, please remove them.

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Dec 22, 2024
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Dec 22, 2024
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@Sonotoki-da
Copy link
Author

I'm sorry for the mess. I shouldn't have been doing any editing with a completely unconfigured environment. I just yesterday started learning about developer productivity tools like ansible because I was a little hurt and frustrated. Haste made waste

@Miodec
Copy link
Member

Miodec commented Dec 23, 2024

Somehow the files have conflicts all of a sudden, plus i can't figure out why the diff on the 70k file is pretty much the whole file..

@Sonotoki-da
Copy link
Author

I probably messed up the whole thing by my incompetence. I'm sorry :'(

Will you let me reopen another PR real quick, if we're to delete this one? But this time, everything will be clean

@Miodec
Copy link
Member

Miodec commented Dec 23, 2024

You can hard reset your master branch, then push the changes to it again and it will not require opening another PR.

@Sonotoki-da
Copy link
Author

Oh, okay. Thank you, I'll try right away

1. Converting all the weird quotes to the simple quote first, using regex: [’`ʼ‘'] -> '
2. Then, regex: ([OoGg])[’`ʼ‘'] -> \1ʻ
3. Finally, regex: [’`ʼ‘'] -> ʼ
@Sonotoki-da Sonotoki-da reopened this Dec 23, 2024
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@Sonotoki-da
Copy link
Author

This is my first PR ever. I never took this collab/coop thing seriously before, but now this is definitely a wake-up call for me. I will learn all the details properly. Thank you for this great opportunity!

Please let me know if I need to do anything to merge the PR. I'll await further instructions, if any 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants