LinkCard.billingAddress typedef fix to reflect most attributes being optional #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Until this is merged, I'll be using our fork as our package version and as a result I need the exports built on install. That's what the prepare script is about. |
curiousercreative
force-pushed
the
main
branch
from
72f2540
to
8dd5916
Compare
|
If you're looking for ways to make this repo more friendly for contributions, I'd recommend gitignoring the lib/types dir. I initially assumed that was the source of type definitions before seeing they were generated from the JSDoc defs. I ran generate-types but decided not to commit the result as almost every typedef file had many changes. |
…ional configure package to build exports when installed
curiousercreative
force-pushed
the
main
branch
from
6bb5bd0
to
f85dab5
Compare
Add cardOnFile attribute to LinkCard typedef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #110