fix: case where not all futures were rejected #207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When debugging aiormq in pycharm, pycharm patches asyncio module. It changes
_asyncio.Future
to a different object thenasyncio.Future
.By changing the condition in
FutureStore.reject_all
fromisinstance(future, asyncio.Future)
toasyncio.isfuture(future)
, it will also be true for the_asyncio.Future
object when debugging in pycharm. The asyncio.isfuture, checks that the given object is compatible to asyncio.Future.https://docs.python.org/3/library/asyncio-future.html#asyncio.isfuture
The problem happened to me in ubuntu 20.04, python 3.8.10, pycharm 2024.1.3 professional.