Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: case where not all futures were rejected #207

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

markmarkmarkthebest
Copy link

When debugging aiormq in pycharm, pycharm patches asyncio module. It changes _asyncio.Future to a different object then asyncio.Future.
By changing the condition in FutureStore.reject_all from isinstance(future, asyncio.Future) to asyncio.isfuture(future), it will also be true for the _asyncio.Future object when debugging in pycharm. The asyncio.isfuture, checks that the given object is compatible to asyncio.Future.
https://docs.python.org/3/library/asyncio-future.html#asyncio.isfuture

The problem happened to me in ubuntu 20.04, python 3.8.10, pycharm 2024.1.3 professional.

…instead of isinstance to support futures from _asyncio module when debugging in pycharm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant