bug-1921849: support elasticsearch 8 #6741
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relud
force-pushed
the
relud-es-8-crash-storage
branch
11 times, most recently
from
d96b425
to
9ac223f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
relud
force-pushed
the
relud-es-8-crash-storage
branch
3 times, most recently
from
32912f9
to
b360970
Compare
relud
commented
Oct 9, 2024
| @@ -458,7 +491,8 @@ def test_get_with_bool_operators(self, es_helper): | |||
|
|
|||
| assert resp["total"] == 2 | |||
| assert len(resp["hits"]) == 2 | |||
| assert not resp["hits"][0]["accessibility"] | |||
| for hit in resp["hits"]: | |||
| assert not hit["accessibility"] | |||
There was a problem hiding this comment.
this test was flaky because it was only checking one hit, checking every hit made it reliably fail until I restored correct behavior.
relud
commented
Oct 11, 2024
| @@ -575,6 +612,8 @@ def _submit_crash_to_elasticsearch( | |||
| # is and fix the document and try again | |||
| field_name = None | |||
|
|
|||
| # TODO(relud) clean this up | |||
There was a problem hiding this comment.
just noticed this note, i'll add some tests and update this error handling
|
@relud Can you rebase this against main? That picks up the changes to move translating between processed crash schema permissions and webapp permissions. Then I can continue working on reviewing this. |
relud
force-pushed
the
relud-es-8-crash-storage
branch
4 times, most recently
from
19b3ea4
to
c0e2cfd
Compare
Co-authored-by: krzepka <rzarol.kepka@gmail.com>
relud
force-pushed
the
relud-es-8-crash-storage
branch
from
c0e2cfd
to
2704c10
Compare
|
@willkg rebase completed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires #6736
use
ELASTICSEARCH_MODE=PREFER_NEWto make the webapp use es8 and the processor write to both es 1.4 and es8