Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug-1918240: Add crash_inconsistencies field from rust-minidump #6759

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

relud
Copy link
Member

@relud relud commented Oct 21, 2024

from :btsoi in bug-1918240:

Rust-minidump has added a feature for detecting inconsistent crashes (see the crash_inconsistencies field in the JSON Schema). It will be helpful to show this on crash-stat to indicate that the crash doesn't make sense and is likely caused by bad hardware.
I think it probably makes sense to treat the field similar to bitflips and have the following support:

  • make it publicly viewable
  • add it to the Details tab in the report view
  • make it searchable in Super Search
  • make it aggregatable in Super Search and Signature report

@relud relud requested a review from a team as a code owner October 21, 2024 16:55
@relud relud requested a review from willkg October 21, 2024 16:55
@relud relud force-pushed the relud-bug-1918240-crash-inconsistencies branch 3 times, most recently from 8fd23fb to b320c6b Compare October 21, 2024 21:29
@relud relud force-pushed the relud-bug-1918240-crash-inconsistencies branch from b320c6b to d8404a1 Compare October 21, 2024 21:33
Copy link
Contributor

@smarnach smarnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I'm not really familiar with this codebase. Here are a couple of questions I can't answer:

  • Do we really need CrashInconsistenciesRule, or is there some other mechanism that can handle trivial cases like this one? Can this possibly be done by CopyFromRawCrashRule?
  • If we need the rule, what file in the socorro/processor/rules directory should it go in?

I presume you know the answers and did everything correctly, so I'll approve. :)

socorro/external/es/super_search_fields.py Outdated Show resolved Hide resolved
socorro/external/legacy_es/super_search_fields.py Outdated Show resolved Hide resolved
Co-authored-by: Sven Marnach <sven@marnach.net>
@relud
Copy link
Member Author

relud commented Oct 24, 2024

* Do we really need `CrashInconsistenciesRule`, or is there some other mechanism that can handle trivial cases like this one? Can this possibly be done by `CopyFromRawCrashRule`?

creating a new rule was suggested by @willkg via zoom when he was explaining how to do this, so I'm going to take that as confirmation a new rule is the right way to go here.

* If we need the rule, what file in the socorro/processor/rules directory should it go in?

I'm confident this should go in breakpad.py because the data source is rust-minidump and all other data generated specfically in that package is handled by rules in that file.

@relud relud enabled auto-merge October 24, 2024 16:51
@relud relud added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit d3187b6 Oct 24, 2024
1 check passed
@relud relud deleted the relud-bug-1918240-crash-inconsistencies branch October 24, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants