-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug-1918240: Add crash_inconsistencies field from rust-minidump #6759
Conversation
8fd23fb
to
b320c6b
Compare
b320c6b
to
d8404a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but I'm not really familiar with this codebase. Here are a couple of questions I can't answer:
- Do we really need
CrashInconsistenciesRule
, or is there some other mechanism that can handle trivial cases like this one? Can this possibly be done byCopyFromRawCrashRule
? - If we need the rule, what file in the socorro/processor/rules directory should it go in?
I presume you know the answers and did everything correctly, so I'll approve. :)
Co-authored-by: Sven Marnach <sven@marnach.net>
creating a new rule was suggested by @willkg via zoom when he was explaining how to do this, so I'm going to take that as confirmation a new rule is the right way to go here.
I'm confident this should go in |
from :btsoi in bug-1918240: