Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MouseManagerRemote.js #919

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update MouseManagerRemote.js #919

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99acaa2
Update MouseManagerRemote.js
teddypee Jan 24, 2018
e7e3eae
Update MouseManagerRemote.js
teddypee Feb 5, 2018
893e538
Update MouseManagerRemote.js
teddypee Feb 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/extensions/default/bramble/lib/MouseManagerRemote.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,21 @@
/*jslint vars: true, plusplus: true, devel: true, nomen: true, indent: 4, forin: true, maxerr: 50, regexp: true, bitwise: true */
/* global addEventListener, removeEventListener, sessionStorage */
(function(transport) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't move this line. You need to wrap the entire module in a function like this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed the code and made the indentation, can you check and get back to me please


var testSessionStorage = "testSessionStorage";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these lines will need to be indented 4-spaces after you restore that function above.

var noop = function() {};
var sessionStorage = {
getItem: noop,
setItem: noop
};

try {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a comment above this that indicates that we're doing this in order to deal with security issues in browsers that don't allow third-party frames to use storage.

window.sessionStorage.setItem(testSessionStorage, testSessionStorage);
window.sessionStorage.removeItem(testSessionStorage);
sessionStorage = window.sessionStorage.bind(window);
} catch(e) {
console.warn("[Bramble] Session storage not accessible for MouseManager.");

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing a closing }. It looks like you've never tested this code, since this would never work. You need to make sure your code a) works; b) passes linting before you submit a PR.

(function(transport) {
"use strict";

var SCROLL_KEY = "___bramble-preview-scrollTop::" + window.___brambleFilename;
Expand Down