Skip to content

Commit

Permalink
BMS control of max charge and discharge is removed by @peterohman
Browse files Browse the repository at this point in the history
or rather prevention of external control)
  • Loading branch information
mr-manuel committed Nov 11, 2024
1 parent 5e7bd4f commit 4b11314
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@
* Added: Possibility to change the CAN bus speed by @mr-manuel
* Added: Threshold, if `CCL = 0` or `DCL = 0` is reached to prevent flapping @mr-manuel
* Changed: Calculate Time-to-Go until ESS -> Minimum SOC (unless grid fails), Active SOC limit or `SOC_LOW_WARNING` from `config.ini` by @mr-manuel
* Changed: HLPDATABMS4S BMS - improved driver with https://github.com/mr-manuel/venus-os_dbus-serialbattery/pull/96 by @peterohman
* Changed: HLPDATA BMS - BMS control of max charge and discharge is removed by @peterohman
* Changed: HLPDATA BMS - improved driver with https://github.com/mr-manuel/venus-os_dbus-serialbattery/pull/96 by @peterohman
* Changed: JKBMS PB Model fixed firmware version and temperature sensors by @KoljaWindeler
* Changed: Rewritten code for external current sensor and fixed https://github.com/mr-manuel/venus-os_dbus-serialbattery/issues/60 by @mr-manuel

Expand Down
6 changes: 0 additions & 6 deletions etc/dbus-serialbattery/bms/hlpdatabms4s.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,6 @@ def read_test_data(self):
self.hardware_version = s1[ix : len(s1) - 1]
self.version = self.hardware_version
self.poll_interval = 10000
self.control_discharge_current = 1000
self.control_charge_current = 1000
if self.cell_count is None:
self.cell_count = 4
for c in range(self.cell_count):
Expand Down Expand Up @@ -213,10 +211,6 @@ def manage_charge_voltage(self):
self.allow_max_voltage = True
self.control_voltage = self.max_battery_voltage

def manage_charge_and_discharge_current(self):
self.control_charge_current = 1000
self.control_discharge_current = 1000

def read_serial_data_HLPdataBMS4S(self, command, time, min_len):
data = read_serial_data(command, self.port, self.baud_rate, time, min_len)
return data
Expand Down

0 comments on commit 4b11314

Please sign in to comment.