Only special case empty Hanzi Math results of subtraction #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, operations like 我+你+我 would return results. This was because empty results of prior operations effectively reset the result, but we only want that with subtraction. 我+你+我 now returns []. Note that this does not address self-adds, which are still broken. It also continues adding all parents in cases like: 我-我+我. The same transitivity is true for normal operations (so 力+口 returns many characters with 另 or 加 as a component, intentionally).
|
Visit the preview URL for this PR (updated for commit a5dd886): https://hanzigraph--pr47-math-empty-list-kru99pqk.web.app (expires Mon, 15 Jul 2024 19:11:55 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dbfc59c053d815dc5dedbd48d2959ec4a33d1b39 |
mreichhoff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, operations like 我+你+我 would return results. This was because empty results of prior operations effectively reset the result, but we only want that with subtraction. 我+你+我 now returns [].
Note that this does not address self-adds, which are still broken. It also continues adding all parents in cases like: 我-我+我. The same transitivity is true for normal operations (so 力+口 returns many characters with 另 or 加 as a component, intentionally).