Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Lower minSdkVersion from 26 to 23 #2414

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mrousavy
Copy link
Owner

What

Lowers the minimum required SDK version from 26 to 23.

Changes

Tested on

Related issues

Copy link

vercel bot commented Jan 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-vision-camera ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2024 5:32pm

@Julesssss
Copy link

Thanks, we'll have no issues with this min version 👍

@mrousavy
Copy link
Owner Author

This is going to be problematic for VisionCamera though, as multiple pieces of the codebase rely on minSdk 26:

  • VideoPipeline: The entire video pipeline will not work anymore if not running on minSdk 26. Video recordings and Frame Processing will error out then.
  • Creating a session: I need to add workarounds there as I use an API from SDK 24.
  • HDR: The entire HDR pipeline needs to be disabled on <26.

@Julesssss
Copy link

Yeah, sorry to be a pain about the min-supported version.

I get that most people don't care about this and would much rather take the newer features. In our case though I'm not sure it's a trade-off worth making. I also wouldn't want us to be the sole reason for having to drop lib features, so maybe we should just seek an alternative? Let me know what you think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants