fix(ClientRequest): do not unshift write buffer when flushing request headers #674
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removes
this.writeBuffer.unshift()
when flushing request write buffer on the firstread()
of the request body stream. This will preserve the first chunk to be sent to the original server in case of passthrough.The fix itself is to call all the write callbacks in order but preserve
this.writeBuffer
so it's forwarded in its entirety over the original socket.