mediatek: snfi: fix return code when reading #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return 0 on succesful read, which may contain correctable bitflips. Fixes: mtk-openwrt#10 Signed-off-by: Daniel Golle <daniel@makrotopia.org>
dangowrt
added a commit
to dangowrt/openwrt
that referenced
this pull request
Aug 11, 2024
A bug has plagued bl2 which caused failure to boot and bricked Linksys E8450 and Belkin RT3200 devices in case of correctable bitflips being detected during a read operation. A simple logic error resulted in read to be considered errornous instead of just continueing in case of correctable bitflips. Address this by importing a patch fixing that logic error. The issue, which has been dubbed as the "OpenWrt Kiss of Death", and is now a thing of the past. Users should preemptively update bl2 to prevent their devices being at risk. Link: mtk-openwrt/arm-trusted-firmware#11 Signed-off-by: Daniel Golle <daniel@makrotopia.org>
grauerfuchs
added a commit
to grauerfuchs/owrt_device_support
that referenced
this pull request
Aug 11, 2024
Thanks to @dangowrt, we now have a fix for OKD on the e8450! mtk-openwrt/arm-trusted-firmware#11 These files are unofficial 2.10 builds with the patch applied.
dangowrt
added a commit
to dangowrt/openwrt
that referenced
this pull request
Aug 12, 2024
A bug has plagued bl2 which caused failure to boot and bricked Linksys E8450 and Belkin RT3200 devices in case of correctable bitflips being detected during a read operation. A simple logic error resulted in read to be considered errornous instead of just continueing in case of correctable bitflips. Address this by importing a patch fixing that logic error. The issue, which has been dubbed as the "OpenWrt Kiss of Death", and is now a thing of the past. Users should preemptively update bl2 to prevent their devices being at risk. Link: mtk-openwrt/arm-trusted-firmware#11 Signed-off-by: Daniel Golle <daniel@makrotopia.org>
King-Of-Knights
pushed a commit
to King-Of-Knights/openwrt-6.x
that referenced
this pull request
Aug 14, 2024
A bug has plagued bl2 which caused failure to boot and bricked Linksys E8450 and Belkin RT3200 devices in case of correctable bitflips being detected during a read operation. A simple logic error resulted in read to be considered errornous instead of just continueing in case of correctable bitflips. Address this by importing a patch fixing that logic error. The issue, which has been dubbed as the "OpenWrt Kiss of Death", and is now a thing of the past. Users should preemptively update bl2 to prevent their devices being at risk. Link: mtk-openwrt/arm-trusted-firmware#11 Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Vladdrako
pushed a commit
to Vladdrako/openwrt
that referenced
this pull request
Aug 19, 2024
A bug has plagued bl2 which caused failure to boot and bricked Linksys E8450 and Belkin RT3200 devices in case of correctable bitflips being detected during a read operation. A simple logic error resulted in read to be considered errornous instead of just continueing in case of correctable bitflips. Address this by importing a patch fixing that logic error. The issue, which has been dubbed as the "OpenWrt Kiss of Death", and is now a thing of the past. Users should preemptively update bl2 to prevent their devices being at risk. Link: mtk-openwrt/arm-trusted-firmware#11 Signed-off-by: Daniel Golle <daniel@makrotopia.org>
liudf0716
pushed a commit
to liudf0716/openwrt
that referenced
this pull request
Aug 25, 2024
A bug has plagued bl2 which caused failure to boot and bricked Linksys E8450 and Belkin RT3200 devices in case of correctable bitflips being detected during a read operation. A simple logic error resulted in read to be considered errornous instead of just continueing in case of correctable bitflips. Address this by importing a patch fixing that logic error. The issue, which has been dubbed as the "OpenWrt Kiss of Death", and is now a thing of the past. Users should preemptively update bl2 to prevent their devices being at risk. Link: mtk-openwrt/arm-trusted-firmware#11 Signed-off-by: Daniel Golle <daniel@makrotopia.org>
c-herz
pushed a commit
to c-herz/openwrt
that referenced
this pull request
Sep 5, 2024
A bug has plagued bl2 which caused failure to boot and bricked Linksys E8450 and Belkin RT3200 devices in case of correctable bitflips being detected during a read operation. A simple logic error resulted in read to be considered errornous instead of just continueing in case of correctable bitflips. Address this by importing a patch fixing that logic error. The issue, which has been dubbed as the "OpenWrt Kiss of Death", and is now a thing of the past. Users should preemptively update bl2 to prevent their devices being at risk. Link: mtk-openwrt/arm-trusted-firmware#11 Signed-off-by: Daniel Golle <daniel@makrotopia.org>
dzzinstant
pushed a commit
to dzzinstant/openwrt
that referenced
this pull request
Sep 9, 2024
A bug has plagued bl2 which caused failure to boot and bricked Linksys E8450 and Belkin RT3200 devices in case of correctable bitflips being detected during a read operation. A simple logic error resulted in read to be considered errornous instead of just continueing in case of correctable bitflips. Address this by importing a patch fixing that logic error. The issue, which has been dubbed as the "OpenWrt Kiss of Death", and is now a thing of the past. Users should preemptively update bl2 to prevent their devices being at risk. Link: mtk-openwrt/arm-trusted-firmware#11 Signed-off-by: Daniel Golle <daniel@makrotopia.org>
dzzinstant
pushed a commit
to dzzinstant/openwrt
that referenced
this pull request
Sep 9, 2024
A bug has plagued bl2 which caused failure to boot and bricked Linksys E8450 and Belkin RT3200 devices in case of correctable bitflips being detected during a read operation. A simple logic error resulted in read to be considered errornous instead of just continueing in case of correctable bitflips. Address this by importing a patch fixing that logic error. The issue, which has been dubbed as the "OpenWrt Kiss of Death", and is now a thing of the past. Users should preemptively update bl2 to prevent their devices being at risk. Link: mtk-openwrt/arm-trusted-firmware#11 Signed-off-by: Daniel Golle <daniel@makrotopia.org>
okoklets
pushed a commit
to okoklets/openwrt
that referenced
this pull request
Sep 11, 2024
A bug has plagued bl2 which caused failure to boot and bricked Linksys E8450 and Belkin RT3200 devices in case of correctable bitflips being detected during a read operation. A simple logic error resulted in read to be considered errornous instead of just continueing in case of correctable bitflips. Address this by importing a patch fixing that logic error. The issue, which has been dubbed as the "OpenWrt Kiss of Death", and is now a thing of the past. Users should preemptively update bl2 to prevent their devices being at risk. Link: mtk-openwrt/arm-trusted-firmware#11 Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return 0 on succesful read, which may contain correctable bitflips.
Fixes: #10