Replace own vector search with Chromem-go #2065
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because my implementation is apparently not producing the expected results and this project fits the bill quite nicely. Most of the tests are failing, but the core functionality appears to work. - [x] Set - [ ] Get - [ ] Delete (we have to delete the whole collection presently) - [ ] Query (it returns normalized embeddings, not the originals) - [x] Query Normalized Some features are missing from Chromem, but we don't strictly need them. Meanwhile there are maybe some minor things that need adding on our side to get the basic functionality working.
✅ Deploy Preview for localai canceled.
|
|
re: deletion, we might want to implement a .Reset() to discard and cleanup the memory? |
|
Yes, I think so. Also I think we need to add IDs to the API (so the vector is not being used for that). part of #1792 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because my implementation is apparently not producing the expected
results and this project fits the bill quite nicely.
Most of the tests are failing, but the core functionality appears to
work.
Some features are missing from Chromem, but we don't strictly need
them. Meanwhile there are maybe some minor things that need adding on
our side to get the basic functionality working.