Fix build for C++20, Fix #53 #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C++20 removed the deprecated std::result_of in favor of std::invoke_result. Switch between usage of those depending on the cpp_lib_is_invocable feature test macro. See: - https://en.cppreference.com/w/cpp/types/result_of - https://en.cppreference.com/w/cpp/feature_test#Library_features
FlyAndNotDown
added a commit
to ExplosionEngine/clipp
that referenced
this pull request
Apr 7, 2022
|
Hi, I need this P.R. merged to use |
|
please consider merging this pr |
|
If you use vcpkg then this patch is being applied care of microsoft/vcpkg#27167 |
knatten
added a commit
to knatten/DumbLang
that referenced
this pull request
Jan 8, 2023
Just lex it and print the tokens, since that's the only thing we can print atm. Run this in CI as a sanity check. I was going to use clipp for cmdline parsing, but it's broken as of C++20: muellan/clipp#53. It also seems to be unmaintained, the PR that fixes it has been open for >2 years: muellan/clipp#54
knatten
added a commit
to knatten/DumbLang
that referenced
this pull request
Jan 8, 2023
Just lex it and print the tokens, since that's the only thing we can print atm. Run this in CI as a sanity check. I was going to use clipp for cmdline parsing, but it's broken as of C++20: muellan/clipp#53. It also seems to be unmaintained, the PR that fixes it has been open for >2 years: muellan/clipp#54 Will need to look into finding a new cmdline parsing library.
the patch still doesn't fix the compilation. i still get this error with c++20 |
|
@danyhm That's a different error that you have. Maybe you can try https://github.com/GerHobbelt/clipp as that seems to be more up to date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #53:
C++20 removed the deprecated std::result_of in favor of
std::invoke_result.
Switch between usage of those depending on the cpp_lib_is_invocable
feature test macro.
See:
An alternative solution would be to use decltype instead of either of those two templates,
if you prefer that I'd be happy to update my PR.