feat: support sni tuple in wss multiaddr #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
reviewed
Oct 25, 2024
achingbrain
requested changes
Oct 25, 2024
The difference is, exact addresses have no trailing tuples, good addresses can have them. So this is an exact WSS multiaddr: This is not: Both would be matched by the When dialing we use exact matchers to decide which transport handles the address, so the first would be handled by the |
Co-authored-by: Alex Potsides <alex@achingbrain.net>
SgtPooki
changed the title
achingbrain
approved these changes
Oct 28, 2024
achingbrain
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Oct 28, 2024
## [1.4.0](v1.3.0...v1.4.0) (2024-10-28) ### Features * support sni tuple in wss multiaddr ([#39](#39)) ([2b687b4](2b687b4))
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure whether we want these addrs to appear inexactWSSorgoodWSSWhen testing ipfs/service-worker-gateway#405, I noticed that js-libp2p was failing to calculate whether multiaddrs were dialable or not.
We received two provider multiaddrs for a CID:
[ "/ip4/147.75.87.65/tcp/4002/tls/sni/147-75-87-65.k51qzi5uqu5dhb03btheentd9nmkaygwm4q3tfrm596s5thf1u87bc7gq0m2ia.libp2p.direct/ws", "/ip6/2604:1380:4601:f600::1/tcp/4002/tls/sni/2604-1380-4601-f600--1.k51qzi5uqu5dhb03btheentd9nmkaygwm4q3tfrm596s5thf1u87bc7gq0m2ia.libp2p.direct/ws" ]the libp2p.direct addrs were being filtered out in https://github.com/libp2p/js-libp2p/blob/717731e49a40142164af6c5c5703f0cad32edbe5/packages/transport-websockets/src/index.ts#L202-L215 and resulting in an error in the console:
libp2p:connection-manager:dial-queue:trace error calculating if multiaddr(s) were dialable +4m NoValidAddressesError: The dial request has no valid addresses