Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LBRY protocol #332

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Add LBRY protocol #332

merged 2 commits into from
Aug 1, 2023

Conversation

ben221199
Copy link
Contributor

This pull request adds a multiaddr for the LBRY network protocol, as described at https://lbry.tech/spec.

table.csv Outdated Show resolved Hide resolved
@ben221199
Copy link
Contributor Author

Changed tag from multiaddr to namespace. I think it is fine now.

@ben221199 ben221199 requested a review from Stebalien July 30, 2023 18:08
@ben221199
Copy link
Contributor Author

Can it be merged, @rvagg?

Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @Stebalien already reviewed this and I had a quick look I dare to approve and merge it.

@ben221199
Copy link
Contributor Author

Thanks @vmx. I would be happy to see it merged. 😃

@vmx vmx merged commit a031693 into multiformats:master Aug 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants