Skip to content

Commit

Permalink
Addendum to 8b979d9
Browse files Browse the repository at this point in the history
  • Loading branch information
@Dutchman101
Dutchman101 authored Sep 15, 2024
1 parent 866b6ea commit 1b3a638
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions Shared/installer/nightly.nsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -688,9 +688,10 @@ SectionGroup /e "$(INST_SEC_CLIENT)" SECGCLIENT


# Added as per https://bitbucket.org/chromiumembedded/cef/commits/8424f166ccef
File "${FILES_ROOT}\mta\CEF\chrome_100_percent.pak"
File "${FILES_ROOT}\mta\CEF\chrome_200_percent.pak"
File "${FILES_ROOT}\mta\CEF\resources.pak"
# Not currently using \mta\cef\ due to https://github.com/chromiumembedded/cef/issues/3749#issuecomment-2278568964 (it's already crashing and likely won't remain supported)
File "${FILES_ROOT}\mta\chrome_100_percent.pak"
File "${FILES_ROOT}\mta\chrome_200_percent.pak"
File "${FILES_ROOT}\mta\resources.pak"

# Clarification for the below 4 deprecated files: https://bitbucket.org/chromiumembedded/cef/commits/8424f166ccef
#File "${FILES_ROOT}\mta\CEF\cef.pak"
Expand Down

2 comments on commit 1b3a638

@Dutchman101
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addendum is in fact to 961dcac, the wrong commit was referenced in desc.

@CrosRoad95
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you even test what are you commiting?

Please sign in to comment.