Fix some small problems with Device Selection Dialog #3851
Conversation
- Show the dialog in task bar - Show the icon on dialog - Display actual monitor names instead of GPU name
|
Is it possible to use translation for the strings in the dialog box so they can vary depending on MTA client language chosen? |
Not with the current approach, but should be possible to do in the future. At this moment I don't touch the dialog creation at all, so i have no control over the UI elements, only thing that's hooked is the message handler for it |
|
(Partially) fixes #3073 |
|
Why is this dialogue needed at all? I suggest turning it off |
A single computer may have several GPUs from different manufacturers in use at the same time, and each GPU be connected to different monitors. (For example, this is commonplace in high-end laptops with Intel CPUs, where both a integrated GPU and discrete GPU are present and used at the same time to balance performance and power usage.) This selection dialogue allows players with such computer configurations to precisely select in which GPU and screen the game should be rendered, which is necessary and useful in those environments. Other games implement such selection within the in-game graphics options (which is a less straightforward thing to do in MTA), have separate, more polished launchers for graphic options (this is unfeasible for MTA), or use a default GPU and screen provided by the operating system graphics APIs (which can be a bad default and inconvenient for the user to change, so it isn't a proper solution for MTA standards either). |
GTA:SA has that dialog before the game boots on a given screen device. If we want to remove it, we can do like most games: if no previously selected screen or previously selected screen no longer connected, auto select the system's default screen; add a setting for changing screen for next launch? (This improvement could be made in a new PR, this PR is already a good bugfix) |
This aims to improve Device Selection dialog that shows on startup if more than one monitor is present. It's partially based on the changes introduced in SilentPatch, although the approach is a bit different.
Changes:
Here's how the dialog looked like before the changes:
And here's the result after the changes:
And here it is in the taskbar:
The main reason for these change is that in most cases the device selection dialog is lost somewhere under all the windows, making it hard to find. I didn't port over all of the changes from SilentPatch, as i wanted to keep it simple for now.