Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Feature: User Activity for #15 #19

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

Feature: User Activity for #15 #19

wants to merge 44 commits into from

Conversation

euantorano
Copy link
Member

This pull request implements the User Activity feature for issue #15.

@euantorano euantorano self-assigned this Mar 20, 2015
@euantorano euantorano added this to the Alpha 1 milestone Mar 20, 2015
@JN-Jones
Copy link
Contributor

Do you also plan to add activities here (posting topic/post) or will you add it separately?
Also you changed the getPresenter in the Post model but not in the others.

@euantorano
Copy link
Member Author

Yes, I plan to add support for core content types in this branch, but will open additional pull requests as other content types are created. And yes, I will change the other models. The only reason I fixed Post here is because I was editing the model anyway.

On 20 Mar 2015, at 14:43, Jones notifications@github.com wrote:

Do you also plan to add activities here (posting topic/post) or will you add it separately?
Also you changed the getPresenter in the Post model but not in the others.


Reply to this email directly or view it on GitHub.

@euantorano euantorano changed the title Feature user activity for #15 Feature: User Activity for #15 Mar 20, 2015
*
* @author MyBB Group
* @version 2.0.0
* @package mybb/settings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn copy and paste. It's probably in a few files ;)

On 21 Mar 2015, at 11:25, Will Pillar notifications@github.com wrote:

In app/UserActivity/Database/Models/UserActivity.php:

@@ -0,0 +1,69 @@
+<?php
+/**


Reply to this email directly or view it on GitHub.

euantorano and others added 11 commits March 21, 2015 21:53
…vity

# By JN-Jones
# Via Euan T. (3) and JN-Jones (2)
* 'master' of github.com:mybb/mybb2:
  Fix last post for forum and topic. Also updated the seeder a bit
  Fix PSR-2 styling
  Fixing forum counters and last_post_id, last_post_user_id updating
  Keep the written reply in the editor when switching to full reply
  Forgot the slug
  Link to the correct topic or forum instead of the action page
…vity

# Conflicts:
#	app/Http/routes.php
#	app/Providers/AppServiceProvider.php
@euantorano
Copy link
Member Author

Basic user activity for replies done. Other activities can be completed in the future as they're implemented. It will also need some nicer styling @justinsoltesz - it currently looks like this:

screen shot 2015-03-29 at 11 03 33

@Sama34
Copy link

Sama34 commented Mar 29, 2015

Totally unrelated but what is with those labels?

Pretty much everything is a new-feature/work-in-progress/feature-enhancement isn't it?

tongue

@euantorano
Copy link
Member Author

@Sama34 They'll be more useful in the future :) It's just good practise to get used to using them now rather than later.

@@ -16,6 +16,8 @@
</header>

{% include "user.profile_basic" %}
<br style="clear: both;" /> {#TODO: Fix this please Justin!#}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinsoltesz For future reference, the profile styling needs some work doing, due to floats and such causing issues...

*
* @return \MyBB\Core\Database\Models\User
*/
public function getContentAuthor()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this return the author of the post and not of the topic?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Not sure what I was thinking there...

…vity

# Conflicts:
#	database/seeds/SettingsTableSeeder.php
#	resources/views/user/profile_activity.twig
…vity

# Conflicts:
#	app/Database/Models/Post.php
#	app/Database/Repositories/Eloquent/SearchRepository.php
#	app/Database/Repositories/SearchRepositoryInterface.php
#	app/Http/Controllers/AbstractController.php
#	app/Http/Controllers/UserController.php
#	app/Likes/Database/Models/Like.php
#	app/Likes/Database/Repositories/Eloquent/LikesRepository.php
#	app/Likes/Database/Repositories/LikesRepositoryInterface.php
#	database/seeds/ProfileFieldsTableSeeder.php
@JN-Jones
Copy link
Contributor

File header should be updated here too ;)

…vity

# Conflicts:
#	app/Http/Controllers/UserController.php
#	app/Http/routes.php
#	app/Likes/Database/Repositories/Eloquent/LikesRepository.php
#	app/Likes/Database/Repositories/LikesRepositoryInterface.php
#	app/Providers/AppServiceProvider.php
#	database/seeds/SettingsTableSeeder.php
#	resources/lang/en/member.php
#	resources/views/user/profile_activity.twig
@euantorano
Copy link
Member Author

TODO:

  • New sub-page to profile to view all activity for a user

@JN-Jones
Copy link
Contributor

Conflicts here too :(

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants