change cli shared library link visibility

myriadrf · Sep 9, 2024 · 2b79b09 · 2b79b09
1 parent dac3cf7
commit 2b79b09
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/cli/CMakeLists.txt b/cli/CMakeLists.txt
@@ -11,7 +11,7 @@ add_library(cli-shared STATIC common.cpp)
 target_include_directories(cli-shared PUBLIC ${CMAKE_CURRENT_LIST_DIR})
 target_link_libraries(cli-shared PUBLIC limesuiteng taywee::args)
 
-target_precompile_headers(cli-shared PUBLIC ${CPP_STL_PCH} \"args.hxx\")
+target_precompile_headers(cli-shared PRIVATE ${CPP_STL_PCH} \"args.hxx\")
 
 add_executable(limeDevice limeDevice.cpp)
 set_target_properties(limeDevice PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin")

diff --git a/src/examples/CMakeLists.txt b/src/examples/CMakeLists.txt
@@ -20,40 +20,40 @@ add_executable(basicRX basicRX.cpp)
 set_target_properties(basicRX PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${examplesOutputDir})
 target_link_libraries(
     basicRX
-    PUBLIC limesuiteng
-    PRIVATE cli-shared kissfft taywee::args)
+    PRIVATE limesuiteng
+    PRIVATE cli-shared kissfft)
 
 add_executable(dualRXTX dualRXTX.cpp)
 set_target_properties(dualRXTX PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${examplesOutputDir})
-target_link_libraries(dualRXTX PUBLIC limesuiteng)
+target_link_libraries(dualRXTX PRIVATE limesuiteng)
 
 add_executable(basicTX basicTX.cpp)
 set_target_properties(basicTX PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${examplesOutputDir})
 target_link_libraries(
     basicTX
-    PUBLIC limesuiteng
+    PRIVATE limesuiteng
     PRIVATE cli-shared kissfft taywee::args)
 
 add_executable(legacyBasicRX legacy/basicRX.cpp)
 set_target_properties(legacyBasicRX PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${examplesOutputDir}/legacy RUNTIME_OUTPUT_NAME basicRX)
-target_link_libraries(legacyBasicRX PUBLIC limesuiteng)
+target_link_libraries(legacyBasicRX PRIVATE limesuiteng)
 
 add_executable(legacyBasicTX legacy/basicTX.cpp)
 set_target_properties(legacyBasicTX PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${examplesOutputDir}/legacy RUNTIME_OUTPUT_NAME basicTX)
-target_link_libraries(legacyBasicTX PUBLIC limesuiteng)
+target_link_libraries(legacyBasicTX PRIVATE limesuiteng)
 
 add_executable(legacyDualRXTX legacy/dualRXTX.cpp)
 set_target_properties(legacyDualRXTX PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${examplesOutputDir}/legacy RUNTIME_OUTPUT_NAME dualRXTX)
-target_link_libraries(legacyDualRXTX PUBLIC limesuiteng)
+target_link_libraries(legacyDualRXTX PRIVATE limesuiteng)
 
 add_executable(legacyGpio_example legacy/gpio_example.cpp)
 set_target_properties(
     legacyGpio_example PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${examplesOutputDir}/legacy RUNTIME_OUTPUT_NAME gpio_example)
-target_link_libraries(legacyGpio_example PUBLIC limesuiteng)
+target_link_libraries(legacyGpio_example PRIVATE limesuiteng)
 
 add_executable(legacySingleRX legacy/singleRX.cpp)
 set_target_properties(legacySingleRX PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${examplesOutputDir}/legacy RUNTIME_OUTPUT_NAME singleRX)
-target_link_libraries(legacySingleRX PUBLIC limesuiteng)
+target_link_libraries(legacySingleRX PRIVATE limesuiteng)
 if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
     target_compile_options(legacySingleRX PRIVATE -Wno-unused-but-set-variable)
 endif()