[Bexley] Add a "Glass" red tag prefix for GL- services #4985
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4985 +/- ##
=======================================
Coverage 82.59% 82.59%
=======================================
Files 393 393
Lines 30764 30764
Branches 4880 4880
=======================================
Hits 25411 25411
Misses 3901 3901
Partials 1452 1452 ☔ View full report in Codecov by Sentry. |
| @@ -1081,7 +1081,8 @@ sub in_cab_logs_reason_prefixes { | |||
| 'Paper & Card' => ['PA-1100', 'PA-1280', 'PA-140', 'PA-240', 'PA-55', 'PA-660', 'PA-940', 'PC-180', 'PC-55'], | |||
| 'Food' => ['FO-140', 'FO-23'], | |||
| 'Garden' => ['GA-140', 'GA-240'], | |||
| 'Plastics & Glass' => ['GL-1100', 'GL-1280', 'GL-55', 'GL-660', 'PG-1100', 'PG-1280', 'PG-240', 'PG-360', 'PG-55', 'PG-660', 'PG-940', 'PL-1100', 'PL-1280', 'PL-140', 'PL-55', 'PL-660', 'PL-940'], | |||
| 'Plastics & Glass' => ['PG-1100', 'PG-1280', 'PG-240', 'PG-360', 'PG-55', 'PG-660', 'PG-940', 'PL-1100', 'PL-1280', 'PL-140', 'PL-55', 'PL-660', 'PL-940'], | |||
| 'Glass' => ['GL-1100', 'GL-1280', 'GL-55', 'GL-660', 'GL-240'], | |||
There was a problem hiding this comment.
If GL-240 is added here, I think it needs to be added to image_for_unit() and _containers too.
I think what has caused confusion, for me at least, is that the spreadsheet (and surrounding conversation) mention 'No longer needed' services - which include GL-240, GL-140, and GL-Node (out of the GL-* types).
There was a problem hiding this comment.
Ah, good catch! I've removed GL-240 in a fixup commit, seemed easiest for the time being. I'll let them know about the "No longer needed" services and see what they say.
mysociety-pusher
force-pushed
the
bexley-wasteworks-add-more-red-tag-prefixes
branch
2 times, most recently
from
c29e7c2
to
a4fa3d2
Compare
The glass containers are being phased out soon in favour of the combined glass and plastic ones, but in the meantime there is a red tag prefix of "Glass" for the older glass-only containers.
mysociety-pusher
force-pushed
the
bexley-wasteworks-add-more-red-tag-prefixes
branch
from
a4fa3d2
to
129329c
Compare
mysociety-pusher
temporarily deployed
to
github-pages
Splits out the services with a GL- prefix into a separate "Glass" prefix for red tags. Also adds a missing GL-240 container type.
For https://3.basecamp.com/4020879/buckets/35109031/todos/7465218614#__recording_7468587102