Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[National Highways] Initialise single-sign on #5114

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

MorayMySoc
Copy link
Contributor

@MorayMySoc MorayMySoc commented Aug 15, 2024

Initial setup for single sign on

Include debugging info to show payload for seeing what fields are used for this and going forward.

https://3.basecamp.com/4020879/buckets/37793327/todos/7702417410#__recording_7705494216

[skip changelog]

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 85.45455% with 8 lines in your changes missing coverage. Please review.

Project coverage is 83.21%. Comparing base (eebbe4f) to head (afb311e).
Report is 32 commits behind head on master.

Files with missing lines Patch % Lines
perllib/FixMyStreet/Cobrand/HighwaysEngland.pm 80.00% 1 Missing and 5 partials ⚠️
perllib/FixMyStreet/App/Controller/Auth/Social.pm 80.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5114      +/-   ##
==========================================
+ Coverage   82.33%   83.21%   +0.87%     
==========================================
  Files         409      409              
  Lines       31973    34459    +2486     
  Branches     5091     5917     +826     
==========================================
+ Hits        26324    28674    +2350     
- Misses       4149     4223      +74     
- Partials     1500     1562      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MorayMySoc MorayMySoc requested a review from dracos August 15, 2024 09:28
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that doesn't matter really if it's only for debugging


my $message = '';
for my $key (sort keys %{$id_token->payload}) {
$message = $message . $key . " : " . $id_token->payload->{$key} . "\n" if $id_token->payload->{$key};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$message .= $key...

@mysociety-pusher mysociety-pusher force-pushed the highways-england-oidc-integration branch from 7cc0089 to eb85622 Compare August 15, 2024 16:34
@dracos dracos changed the title [Highways England] Initialise single-sign on [National Highways] Initialise single-sign on Sep 13, 2024
Copy link
Contributor

@neprune neprune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dracos dracos force-pushed the highways-england-oidc-integration branch 2 times, most recently from 4d79338 to 5c5a381 Compare September 19, 2024 11:10
@dracos dracos force-pushed the highways-england-oidc-integration branch from d4c7816 to 0161b00 Compare October 14, 2024 16:19
@dracos dracos force-pushed the highways-england-oidc-integration branch from a443492 to 078981e Compare October 24, 2024 12:25
@dracos dracos force-pushed the highways-england-oidc-integration branch from 1ebeedb to afb311e Compare October 25, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants