Skip to content

Commit

Permalink
FIXUP outdated comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Jeremy Rand committed Jun 13, 2022
1 parent 4c4c539 commit 427bfed
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions src/qt/nametablemodel.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,6 @@ class NameTablePriv
std::map<std::string, NameTableEntry> vNamesO;

// confirmed names (name_list)
// TODO: Set name and value encoding to hex, so that nonstandard
// encodings don't cause errors.

UniValue params(UniValue::VOBJ);
UniValue options(UniValue::VOBJ);
Expand Down Expand Up @@ -107,6 +105,8 @@ class NameTablePriv
continue;
}

// TODO: Properly handle non-ASCII names/data.

const std::string hexName = maybeName.get_str();
std::string name;
try
Expand Down Expand Up @@ -151,8 +151,6 @@ class NameTablePriv
}

// unconfirmed names (name_pending)
// TODO: Set name and value encoding to hex, so that nonstandard
// encodings don't cause errors.

UniValue pendingNames;
try {
Expand All @@ -178,6 +176,8 @@ class NameTablePriv
continue;
}

// TODO: Properly handle non-ASCII names/data.

const std::string hexName = maybeName.get_str();
std::string name;
try
Expand Down Expand Up @@ -562,6 +562,8 @@ QString NameTableModel::update(const QString &name, const std::optional<QString>

UniValue params(UniValue::VOBJ);

// TODO: Properly handle non-ASCII names/data.

try
{
const QString hexName = NameTableModel::asciiToHex(name);
Expand Down

0 comments on commit 427bfed

Please sign in to comment.