Skip to content

Commit

Permalink
Rescue reads rejected by start time. Recovers ~10%
Browse files Browse the repository at this point in the history
  • Loading branch information
ollenordesjo committed Dec 9, 2022
1 parent bf3dc89 commit da36bc9
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [v0.2.19]
### Fixed
- Bug where approximate start times led to incorrectly rejecting candidate duplex pairs.

## [v0.2.18]
### Fixed
- Bug where aligned BAMs would be used as inputs to filter_pairs. This meant running `filter_pairs` on a guppy directory would report an incorrect duplex rate
Expand Down
2 changes: 1 addition & 1 deletion duplex_tools/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"split_on_adapter", "assess_split_on_adapter",
"pairs_from_summary", "filter_pairs", "pair"]

__version__ = '0.2.18'
__version__ = '0.2.19'


def main():
Expand Down
2 changes: 1 addition & 1 deletion duplex_tools/pairs_from_summary.py
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ def seqsummary_to_tempcompsummary(
logger = duplex_tools.get_named_logger("FindPairs")
# Default filtering
seqsummary["candidate_followon"] = (
(-0.01 <= seqsummary["duration_until_next_start"])
(-1.00 <= seqsummary["duration_until_next_start"])
& (seqsummary["duration_until_next_start"] < max_time_between_reads))
logger.info(f'{seqsummary["candidate_followon"].sum()} pairs after '
f'filtering on duration between reads. (max '
Expand Down

0 comments on commit da36bc9

Please sign in to comment.