Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge all entity groups into one #573

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Merge all entity groups into one #573

wants to merge 22 commits into from

Conversation

Ptroger
Copy link
Contributor

@Ptroger Ptroger commented Oct 30, 2024 •
edited
Loading

Overview

This PR is updating entity schema. The first objective is to merge accountGroups and userGroups into groups
The other objective was to make this change non breakable.

Challenges

  • Entities is a shared schema across our stack that is validated
  • We have entities signed and used in prod.
  • We want to have a solution for any change, not just this one

Solution

  • Entities is an 'append only' schema
  • New fields and updated ones are optional
  • Default 'empty' entities used for management is up to date with latest schema
  • Policies will have versions when a schema change won't be reconcilable in rego
    • Currently doesn't have to be the case - rego v0 implementation supports this change
  • Deprecated fields still in usage are flagged at entity validation
  • Runbook for subsequent changes

@vercel Vercel
Copy link

vercel bot commented Oct 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
devtool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 5:47pm
manager 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 5:47pm

@Ptroger Ptroger marked this pull request as ready for review October 30, 2024 12:50
@Ptroger
mixed groups in typescript entities
2a8b01f
@Ptroger
fixed expected data in test with unique group
ffdedb3
@Ptroger
fixed groups naming in fixture and tests data
286bb29
@Ptroger
added origin to vault return in e2e test - leftover bug from another …
a3c6a50 
…work
@Ptroger
updated rego tests and test data
c32722b
@Ptroger
added versionning support in entity util
98e20a8
@Ptroger
updated devtool to handle versions
13fc5ff
@Ptroger
removed unused function - updated comment to be clearer
72fe195
@Ptroger
Revert "removed unused function - updated comment to be clearer"
63a56cc 
This reverts commit c48adef.
@Ptroger
Revert "updated devtool to handle versions"
d9ebba4 
This reverts commit cca8184.
@Ptroger
Revert "added versionning support in entity util"
08121cc 
This reverts commit 19c08e5.
@Ptroger
entity query lib accept legacy and new groups
0205334
@Ptroger
supporting both legacy and new groups
99ac586
@Ptroger
removed unecessary group duplication in rego
68eb936
@Ptroger
make all fields optional
a2c3536
@Ptroger
made deprecated and new fields optional
6755a1e
@Ptroger
updated sdk client
1dd798e
@Ptroger
re-added default deprecated entities to not break entity management u…
aec151a 
…sing sdk
@Ptroger
re-added deprecated fields to empty state for now
f254d5a
@Ptroger
moved the "join table" to a separate field in the entity schema
6c7589d
@Ptroger Ptroger force-pushed the feature/nar-1920-merge-groups-and-destination-groups-new branch from 5483285 to 6c7589d Compare November 12, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcalderipe wcalderipe Awaiting requested review from wcalderipe wcalderipe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Ptroger