Fix #249, adu size option for bpcat #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
force-pushed
the
fix-249-bundle-size
branch
from
d4b8eea
to
094f1a1
Compare
glan6388
approved these changes
Sep 25, 2023
Adds a "-s" command line option to allow the ADU size to be configured at runtime. The existing value becomes the maximum and default.
jphickey
force-pushed
the
fix-249-bundle-size
branch
from
094f1a1
to
fc7634b
Compare
jphickey
added
ccb:approved
|
Reviewed and approved at 2023-09-27 CCB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Adds a "-s" command line option to allow the ADU size to be configured at runtime. The existing value becomes the maximum and default.
Fixes #249
Testing performed
Run bpcat, observe output
Expected behavior changes
The "-s" option allows ADU size to be configured
System(s) tested on
Debian
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.