net2cog - Ensure test suite does not fail for unconfigured environments. #107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR came up from skimming recent regression test failures for a Harmony production deployment. The cell that currently verifies the output for the first test will always try to run, even if there is no configuration information for an environment. In this case, production has no collection information, so none of the tests or verification should run.
This PR just wraps the cell in question with a check that things are configured.
Jira Issue ID
N/A
Local Test Steps
main
branch. Run thenet2cog
test suite (use instructions below). This will fail withNameError: name 'harmony_client' is not defined
.net2cog
test suite (using same instructions below). This should now pass. Check thetest/output/net2cog/Results.ipynb
output - it should have print statements outputting that the cells were skipped.export HARMONY_HOST_URL=https://harmony.uat.earthdata.nasa.gov
, then re-run the test suite with./run_notebooks.sh net2cog
. The test suite should also still pass against UAT (but should take longer than the production run, because it's actually running the tests). Check thetest/output/net2cog/Results.ipynb
output - it should look like the tests were fully executed.PR Acceptance Checklist
Acceptance criteria metTests added/updated (if needed) and passing