-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
713 risk matrix (under development) #724
Open
rob-taggart
wants to merge
10
commits into
nci:develop
Choose a base branch
from
rob-taggart:713-risk_matrix
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To do:
|
rob-taggart
force-pushed
the
713-risk_matrix
branch
from
November 5, 2024 02:55
062078a
to
9583e02
Compare
rob-taggart
force-pushed
the
713-risk_matrix
branch
from
November 5, 2024 06:28
023e53d
to
2d0eb90
Compare
@nicholasloveday , this PR is ready for review now, including a tutorial. I've uploaded a version of the paper, which explains the score. Happy to talk you through it before you review so you know the salient bits. |
@nicholasloveday , one thing I didn't do is link the tutorial to the API. Will need to address this in the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please work through the following checklists. Delete anything that isn't relevant.
Development for new xarray-based metrics
reduce_dims
,preserve_dims
, andweights
args.Testing of new xarray-based metrics
xr.Dataarrays
andxr.Datasets
Tutorial notebook
Documentation