Merge pull request solidusio#5632 from mamhoff/deprecate-adjustment-r…

…ecalculate

Deprecate Spree::Adjustment#recalculate

core/app/models/spree/adjustment.rb

@@ -122,6 +122,7 @@ def recalculate
       end
       amount
     end
+    deprecate :recalculate, deprecator: Spree.deprecator
 
     # Calculates based on attached promotion (if this is a promotion
     # adjustment) whether this promotion is still eligible.

core/lib/spree/testing_support/factories/adjustment_factory.rb

@@ -31,7 +31,7 @@
             adjustment.source.tax_categories = []
           end
           adjustment.source.save
-          adjustment.recalculate
+          adjustment.update!(amount: adjustment.source.compute_amount(adjustment.adjustable))
         end
       end
     end

core/spec/models/spree/adjustment_spec.rb

@@ -92,6 +92,12 @@
     let(:order) { create(:order_with_line_items, line_items_price: 100) }
     let(:line_item) { order.line_items.to_a.first }
 
+    around do |example|
+      Spree.deprecator.silence do
+        example.run
+      end
+    end
+
     context "when adjustment is finalized" do
       let(:finalized) { true }