[pull] main from solidusio:main #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Adjust after rubocop changes
pull
bot
added
⤵️ pull
and removed
changelog:repository
changelog:solidus_backend
changelog:solidus_api
changelog:solidus_core
changelog:solidus_sample
labels
Block handling in ERB is different than a regular method. Regular methods are interested in the return value, while for ERB we need to capture the ERB output produced by running the block and discard the return value. The `capture` method does just that.
Also moves `#icon` from a sequential argument to a keyword argument. The list of sections was only used to match the current path, because top-level menu items should be active whenever any of the children items are active.
The first part will just setup options and the bottom of the method takes care of generating the "tab".
The menu item will now be able to tell if a request matches itself.
Use MenuItem instances for second level backend menus instead of partials.
The condition option was duplicating what the children were already checking.
Rely on the implicit array ordering.
[Backend] cleanup `MenuItems` generation
Added missing select2_local es-CL
Added es-CL select2_locale js
There is no code path that creates adjustments from return authorizations (since a long time). This line was introduced without a lot of context in 2013, and there is nothing in the current codebase that warrants this scope.
…izations-scope Remove Spree::Adjustment.return_authorization scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )