forked from solidusio/solidus
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] main from solidusio:main #379
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add use_shipping attribute with syncing logic to `Spree::Order` model. Similar to the existing `use_billing` feature, a `use_shipping` attribute has been introduced. This addition enables the automatic assignment of the shipping address to the billing address when the `use_shipping` flag is set. The `before_validation` callbacks ensure that the addresses are synchronized, thereby streamlining the address management process in the new admin interface.
- Introduce a new `AddressesController` to handle the creation and updating of billing and shipping addresses for orders. Includes new and update actions with strong parameter support and address type validation. - Add links for address management to customer section component.
Leverage the existing `ui/forms/address` component to render the address forms within the admin order process.
Modify the style definitions for city and zipcode fields to ensure consistent height alignment with other fields in the form.
Enhance the address form's state field by ensuring the correct state is selected during asynchronous loading. This adjustment addresses a timing issue where Stimulus did not populate the state select promptly, leading to mismatched selections.
Modify the address form logic to accommodate countries without associated states. The state select field is now automatically disabled when a country with no states is selected. Additionally, this ensure state select field is disabled for preloaded selected country without states.
Corrected the Stimulus controller event handling to ensure dropdown <details> close on modal open/close. Previously, the `turbo:before-cache` event was not properly connected to the Stimulus controller, causing menus to remain open after a modal was triggered. The 'closeMenus' method within the controller was attempting to call 'querySelectorAll' on 'this.event', which is undefined within the Stimulus context. This update corrects the 'closeMenus' method to reference 'this.element', ensuring that it correctly targets the controller's DOM element.
[Admin] Order process: Integrate address form component for billing and shipping
pull
bot
added
⤵️ pull
and removed
changelog:solidus_api
changelog:solidus_core
changelog:solidus_admin
labels
Nov 8, 2023
The search component becomes more adaptable this way and can be placed in more ways within or without a panel. The panel component gained an `actions` slot and updated paddings, removing the need for the previously used negative margins.
The button that we used initially was to high.
Also make the header and footer sticky.
Remove the title so that "Customer" will only refer to Spree::User.
SolidusAdmin customer picker for order
[admin] Move layout related components under `layout/`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )