Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from solidusio:main #379

Merged
merged 24 commits into from
Nov 15, 2023
Merged

[pull] main from solidusio:main #379

merged 24 commits into from
Nov 15, 2023

Conversation

pull[bot]
Copy link

@pull pull bot commented Nov 8, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

Add use_shipping attribute with syncing logic to `Spree::Order` model.
Similar to the existing `use_billing` feature, a `use_shipping` attribute
has been introduced.
This addition enables the automatic assignment of the shipping address
to the billing address when the `use_shipping` flag is set.
The `before_validation` callbacks ensure that the addresses are
synchronized, thereby streamlining the address management process
in the new admin interface.
- Introduce a new `AddressesController` to handle the creation and updating of
  billing and shipping addresses for orders. Includes new and update actions
  with strong  parameter support and address type validation.
- Add links for address management to customer section component.
Leverage the existing `ui/forms/address` component to render the address forms
within the admin order process.
Modify the style definitions for city and zipcode fields to ensure
consistent height alignment with other fields in the form.
Enhance the address form's state field by ensuring the correct state is selected
during asynchronous loading.
This adjustment addresses a timing issue where Stimulus did not populate the
state select promptly, leading to mismatched selections.
Modify the address form logic to accommodate countries without associated
states.
The state select field is now automatically disabled when a country with no
states is selected.
Additionally, this ensure state select field is disabled for preloaded
selected country without states.
Corrected the Stimulus controller event handling to ensure
dropdown <details> close on modal open/close.
Previously, the `turbo:before-cache` event was not properly connected to
the Stimulus controller, causing menus to remain open after a modal was triggered.

The 'closeMenus' method within the controller was attempting to call
'querySelectorAll' on 'this.event', which is undefined within the Stimulus context.

This update corrects the 'closeMenus' method to reference 'this.element',
ensuring that it correctly targets the controller's DOM element.
[Admin] Order process: Integrate address form component for billing and shipping
[admin] Move layout related components under `layout/`
@pull pull bot merged commit 9ed9a07 into nebulab:main Nov 15, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants