[pull] main from solidusio:main #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
- Use stimulus params instead of arbitrary data attributes - Only attach the url if the url proc is defined - Improve detection of default-clickable elements for which the row url shouldn't be used
This is why `data-turbo-method` wasn't working.
Should save one or two extra roundtrips to the database.
Also changes how `<col>` attributes are provided.
[admin] Misc improvements
pull
bot
added
⤵️ pull
and removed
changelog:repository
changelog:solidus_core
changelog:solidus_admin
labels
This helps keeping the query URL short. Co-Authored-By: Rainer Dema <rainer.dema@gmail.com>
Using not-allowed can be confusing when a button is disabled temporarily while submitting a form. Co-Authored-By: Rainer Dema <rainer.dema@gmail.com>
This helps not interpreting a domain as a relative path. Also points the logo to the root of the admin. Co-Authored-By: Rainer Dema <rainer.dema@gmail.com>
The list of kwargs and the number of objects was very high, after this we can delegate some of the logic to supporting classes. Grouping by data and search kwargs might also help in future splitting or extraction of subcomponents. Co-Authored-By: Rainer Dema <rainer.dema@gmail.com>
… mode Co-Authored-By: Rainer Dema <rainer.dema@gmail.com>
…h mode Co-Authored-By: Rainer Dema <rainer.dema@gmail.com>
This will be also the home for the upcoming scope support. Co-Authored-By: Rainer Dema <rainer.dema@gmail.com>
Scopes are alternative pools of record on which further filtering can be performed. Co-Authored-By: Rainer Dema <rainer.dema@gmail.com>
Co-Authored-By: Rainer Dema <rainer.dema@gmail.com>
Co-Authored-By: Rainer Dema <rainer.dema@gmail.com>
…-features [admin] Add scopes and controller helpers for `ui/table`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )