[pull] main from solidusio:main #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
`Spree::Order#ensure_promotions_eligible` uses the `Spree::Adjustment#calculate_eligibility` in order to determine whether the order's promo total might change. `Spree::Adjustment` should probably not know too much about promotion eligibility, and the error message we add to the order also does only talks about the promo total changing.
The default order promotion adjuster duplicates this logic, and `calculate_eligibility` should now not be called from anywhere in the codebase during normal operation.
the common form pattern in the solidus admin is to have the buttons be centered at the bottom. when the flash message would display, it would cover up those buttons before it fades, leading to a bit of a slow admin process waiting for the flash to go away due to it covering key buttons this revises the styles so the flash message shows in the lower right like a little toaster, out of the way of most buttons on a desktop monitor this change comes by way of using the solidus admin daily and wishing the flash didn't overlap the buttons this only applies to the legacy UI, as the new UI no longer has this problem
…-payment-methods-index-component [Admin] Include pagination in `payment_methods/index` component
…-in-callback Use configurable promo adjuster in callback
chore(admin): restyle legacy UI flash to not overlap buttons
Enable the admin preview by default for new installations
pull
bot
added
⤵️ pull
and removed
changelog:repository
changelog:solidus_backend
changelog:solidus_core
changelog:solidus_admin
labels
Update installer specs to match the new starter content
With Rails 7.1, callbacks only work with actions that are defined on the controller. This check allowed us to notice we had this some no more used actions. This commit also enable the new configuration in the dummy app so we will be able to spot new errors. The configuration needs to be defined explicitely because it's not part of the load_defaults but it's copied in the dummy application directly. Took advantage of the change for adding another 7.1-only configuration to the dummy app: config.action_dispatch.show_exceptions = :none
Removed the load_promotion_category method and its corresponding before_action for the non-existent :move action.
Remove unused action in controller callbacks
This code has been automatically generated by our 'Prepare release' GitHub action. The actual release is not part of the automation, and it still needs to be manually done by a maintainer.
This is the most probable cause of previous flakyness.
Ensure the customer returns specs leverages time outs
…703270526 Prepare release for Solidus v4.3.0
Post release GH actions fix
This code has been automatically generated by our 'Prepare post-release' GitHub action. Make sure that: - [ ] The new release has been published, along with its tag. See https://github.com/solidusio/solidus/releases/tag/v4.3.0 - [ ] The corresponding patch branch exists. See https://github.com/solidusio/solidus/tree/v4.3 - [ ] The corresponding backport-v4.3 label exists. See https://github.com/solidusio/solidus/labels
…703678274 Post-release chores after having released Solidus v4.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )