[pull] main from solidusio:main #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Puma 6 was disallowed in 2022, because back then Rails itself generated Gemfiles with `'puma', "< 6". This is not the case anymore, in fact, Rails comes with Rack 3 which instead is incompatible with Puma 5.
When using the navigation from a gem that isolates its namespace in such a way that the default route helper is not `spree`, this partial fails to render with an undefined method error. This can easily be fixes by prefixing the route helper with Solidus' routing proxy.
Allow Puma 6 in development
…helper Use `spree` routing proxy in theme selection partial
When using the navigation from a gem that isolates its namespace in such a way that the default route helper is not spree, this partial fails to render with an undefined method error. This can easily be fixed by prefixing the route helper with Solidus' routing proxy. This is the same problem and solution as #5599, just for the theme selection partial that is used when using the current admin (rather than the new one).
pull
bot
added
⤵️ pull
and removed
changelog:repository
changelog:solidus_backend
labels
…outing-proxy Theme selection for Solidus Admin: Use spree routing proxy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )