[pull] main from solidusio:main #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Currently, running `rails g solidus:install` on a new rails app bundles `solidus_admin` with version `0.0.0`, which is empty. This leads to inconsistencies, the first one being the dedicated `solidus_admin` generator is not found and consequently cannot be run.
…-admin-install Bundle solidus_admin >= 0.2 in Solidus installer
This prevent the following error when the `.gitignore` file is not present, for example when creating sandbox app: Rails::Generators::Error: The template [/path/to/solidus/admin/lib/solidus_admin/install_tailwindcss.rb] could not be loaded. Error: The file /path/to/solidus/sandbox/.gitignore does not appear to exist (Rails::Generators::Error) Caused by: Thor::Error: The file /path/to/solidus/sandbox/.gitignore does not appear to exist (Thor::Error)
This avoids errors when running the installer on apps that already include that gem, for example when creating the sandbox.
Fix minor sandbox generation issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )