[pull] main from solidusio:main #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Unit cancel adjustments are always finalized, and will thus never be recalculated. Attempting to do so by un-finalizing them will result in a ZeroDivisionError. Let's not try.
Since the gem has specific releases, it makes sense to point to its specific readme, code path and changelog URL. Co-Authored-By: Elia Schito <elia@schito.me> Co-Authored-By: Rainer Dema <rainer.dema@gmail.com>
A few new sections are added, while other are edited in order to better describe the current state of the new admin. Co-Authored-By: Elia Schito <elia@schito.me> Co-Authored-By: Rainer Dema <rainer.dema@gmail.com>
…-code-path Remove call to private method `#update_cancellations` from `OrderUpdater#recalculate_adjustments`
Sample products data was reworked with /pull/5437. After these changes, some products with variants remained without option types, meaning that their variants remained not visible and selectable on the FE, and in the admin it was not possible to add new ones as the relevant button was hidden.
…ct-option-types Add missing option types to product sample data
To enhance the developer-friendliness and interactivity of stack traces, particularly those from components in the new admin.
…-to-sandbox Add `better_errors` gem to the sandbox
Without this we get
uninitialized constant Spree::AppConfiguration::URI
errors.
Explicitly require URI in app configuration
The menu item should not match the url if a match_path prevents this behavior. Previously the match_path method went truthy, if the url of the menu item started with the same url as the request regardless of the given match_path - configuration.
Menu item should not match url if match_path is set
…r-promotion_orders-promotions-foreign-key Fix down migration for promotion_orders promotions foreign key
[admin] Document SolidusAdmin intended usage and how to contribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )