Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(run-tests): update actions/upload-artifact from 3 to 4 #2535

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Juneezee
Copy link
Contributor

For some reasons, Dependabot did not detect the upload-artifact@v3 in PR #2133.

v3 of actions/upload-artifact and actions/download-artifact will be fully deprecated by 5 December 2024. Jobs that are scheduled to run during the brownout periods will also fail. See:

  1. https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
  2. https://github.blog/changelog/2024-11-05-notice-of-breaking-changes-for-github-actions/

For some reasons, Dependabot did not detect the `upload-artifact@v3` in
PR nektos#2133.

v3 of `actions/upload-artifact` and `actions/download-artifact` will be
fully deprecated by 5 December 2024. Jobs that are scheduled to run
during the brownout periods will also fail. See [1][2].

[1]: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
[2]: https://github.blog/changelog/2024-11-05-notice-of-breaking-changes-for-github-actions/

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
@Juneezee Juneezee requested a review from a team as a code owner November 20, 2024 10:32
Copy link
Contributor

mergify bot commented Nov 20, 2024

@Juneezee this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.01%. Comparing base (5a80a04) to head (04652d7).
Report is 132 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2535       +/-   ##
===========================================
+ Coverage   61.56%   75.01%   +13.44%     
===========================================
  Files          53       62        +9     
  Lines        9002    10013     +1011     
===========================================
+ Hits         5542     7511     +1969     
+ Misses       3020     1936     -1084     
- Partials      440      566      +126     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mergify mergify bot removed the needs-work Extra attention is needed label Nov 20, 2024
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, while I would have just let this fail before doing anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants