Skip to content

Commit

Permalink
Un-deprecates JsFunction::{call, exec, construct} as lower-level pr…
Browse files Browse the repository at this point in the history
…imitives (which have also existed for a while, so it's a more invasive change for existing users than deprecating `call_with` and `construct_with`).
  • Loading branch information
dherman committed Oct 2, 2024
1 parent d7b27ef commit 7302671
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions crates/neon/src/types_impl/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1119,8 +1119,7 @@ impl JsFunction {
impl JsFunction {
/// Calls this function.
///
/// **See also:** [`JsFunction::call_with`].
#[deprecated(since = "TBD", note = "use `JsFunction::bind` instead")]
/// **See also:** [`JsFunction::bind`].
pub fn call<'a, 'b, C: Context<'a>, T, AS>(
&self,
cx: &mut C,
Expand All @@ -1136,8 +1135,7 @@ impl JsFunction {

/// Calls this function for side effect, discarding its result.
///
/// **See also:** [`JsFunction::call_with`].
#[deprecated(since = "TBD", note = "use `JsFunction::bind` instead")]
/// **See also:** [`JsFunction::bind`].
pub fn exec<'a, 'b, C: Context<'a>, T, AS>(
&self,
cx: &mut C,
Expand All @@ -1154,8 +1152,7 @@ impl JsFunction {

/// Calls this function as a constructor.
///
/// **See also:** [`JsFunction::construct_with`].
#[deprecated(since = "TBD", note = "use `JsFunction::bind` instead")]
/// **See also:** [`JsFunction::bind`].
pub fn construct<'a, 'b, C: Context<'a>, AS>(
&self,
cx: &mut C,
Expand Down

0 comments on commit 7302671

Please sign in to comment.