Refactor MigrationRunner::run_migrations() to call a helper #10232
+33
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristan957
requested review from
lubennikovaav
and removed request for
a team
7216 tests run: 6863 passed, 0 failed, 353 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
0ce45be at 2024-12-23T22:39:46.065Z :recycle: |
This will make it easier to add cluster migrations, such as that for CVE-2024-4317. Link: https://www.postgresql.org/support/security/CVE-2024-4317/ Signed-off-by: Tristan Partin <tristan@neon.tech>
tristan957
force-pushed
the
tristan957/refactor
branch
from
780f4e6 to
0ce45be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier to add per-db migrations, such as that for
CVE-2024-4317.
Link: https://www.postgresql.org/support/security/CVE-2024-4317/
Signed-off-by: Tristan Partin tristan@neon.tech