Skip to content

Commit

Permalink
TASK: Remove use of save-points for projections
Browse files Browse the repository at this point in the history
see neos/neos-development-collection#5321 (comment)

the save-point will only be used for REAL projection errors now and never rolled back if catchup errors occur.

With that change in code the save-points are less important because a real projection error should better be thrown at the start before any statements, and even if some statements were issued and a full rollback is done its unlikely that a reactivateSubscription helps that case.

Instead, to repair projections you should replay
  • Loading branch information
mhsdesign committed Dec 10, 2024
1 parent 90adfaa commit 7fb690d
Showing 1 changed file with 0 additions and 15 deletions.
15 changes: 0 additions & 15 deletions Classes/Factory/SubscriptionStore/DoctrineSubscriptionStore.php
Original file line number Diff line number Diff line change
Expand Up @@ -171,19 +171,4 @@ public function transactional(\Closure $closure): mixed
{
return $this->dbal->transactional($closure);
}

public function createSavepoint(): void
{
$this->dbal->createSavepoint('SUBSCRIBER');
}

public function releaseSavepoint(): void
{
$this->dbal->releaseSavepoint('SUBSCRIBER');
}

public function rollbackSavepoint(): void
{
$this->dbal->rollbackSavepoint('SUBSCRIBER');
}
}

0 comments on commit 7fb690d

Please sign in to comment.