TASK: Make workspace role and metadata creation atomic

neos · Dec 12, 2024 · 08d01e1 · 08d01e1
1 parent ddccba1
commit 08d01e1
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 8 deletions.
diff --git a/Neos.Neos/Classes/Domain/Repository/WorkspaceMetadataAndRoleRepository.php b/Neos.Neos/Classes/Domain/Repository/WorkspaceMetadataAndRoleRepository.php
@@ -360,4 +360,13 @@ public function findWorkspaceNameByUser(ContentRepositoryId $contentRepositoryId
         ]);
         return $workspaceName === false ? null : WorkspaceName::fromString($workspaceName);
     }
+
+    /**
+     * @param \Closure(): void $fn
+     * @return void
+     */
+    public function transactional(\Closure $fn): void
+    {
+        $this->dbal->transactional($fn);
+    }
 }
diff --git a/Neos.Neos/Classes/Domain/Service/WorkspaceService.php b/Neos.Neos/Classes/Domain/Service/WorkspaceService.php
@@ -132,10 +132,13 @@ public function createRootWorkspace(ContentRepositoryId $contentRepositoryId, Wo
                 ContentStreamId::create()
             )
         );
-        $this->metadataAndRoleRepository->addWorkspaceMetadata($contentRepositoryId, $workspaceName, $title, $description, WorkspaceClassification::ROOT, ownerUserId: null);
-        foreach ($assignments as $assignment) {
-            $this->metadataAndRoleRepository->assignWorkspaceRole($contentRepositoryId, $workspaceName, $assignment);
-        }
+
+        $this->metadataAndRoleRepository->transactional(function () use ($contentRepositoryId, $workspaceName, $title, $description, $assignments) {
+            $this->metadataAndRoleRepository->addWorkspaceMetadata($contentRepositoryId, $workspaceName, $title, $description, WorkspaceClassification::ROOT, ownerUserId: null);
+            foreach ($assignments as $assignment) {
+                $this->metadataAndRoleRepository->assignWorkspaceRole($contentRepositoryId, $workspaceName, $assignment);
+            }
+        });
     }
 
     /**
@@ -182,10 +185,13 @@ public function createSharedWorkspace(ContentRepositoryId $contentRepositoryId,
                 ContentStreamId::create()
             )
         );
-        $this->metadataAndRoleRepository->addWorkspaceMetadata($contentRepositoryId, $workspaceName, $title, $description, WorkspaceClassification::SHARED, ownerUserId: null);
-        foreach ($assignments as $assignment) {
-            $this->metadataAndRoleRepository->assignWorkspaceRole($contentRepositoryId, $workspaceName, $assignment);
-        }
+
+        $this->metadataAndRoleRepository->transactional(function () use ($contentRepositoryId, $workspaceName, $title, $description, $assignments) {
+            $this->metadataAndRoleRepository->addWorkspaceMetadata($contentRepositoryId, $workspaceName, $title, $description, WorkspaceClassification::SHARED, ownerUserId: null);
+            foreach ($assignments as $assignment) {
+                $this->metadataAndRoleRepository->assignWorkspaceRole($contentRepositoryId, $workspaceName, $assignment);
+            }
+        });
     }
 
     /**