FEATURE: Add ContentSubgraphInterface::findClosestNode()

[bwaidelich]

Resolves: #4517

[mhsdesign]

Hi, just a though, what about naming it findClosest instead and possibly include the current node in the result set if it matches already?

Then this would be an actual 1 to 1 drop in for findClosestDocumentNode as we want return the current node if its an document already.

$documentNode = $subgraph->findClosestNode($node->nodeAggregateId, FindClosestNodeFilter::create(nodeTypeConstraints: 'Neos.Neos:Document');

[bwaidelich]

@mhsdesign that's a very good point, that makes the query much more useful. Adjusted with cddc41d

[mhsdesign]

before merging this i would like to discuss how we want to ideally fetch all the necessary nodes for the fusion view.

Based on an entryNode, we need documentNode and siteNode.

So the document node can be found via this PR findClosestNode - but what about the site?

I had the idea to combine both lookups into one query:

$ancestors = $subgraph->findAncestorNodes($node->nodeAggregateId, FindAncestorNodesFilter::create(nodeTypeConstraints: 'Neos.Neos:Document');

$documentNode = $node->nodeType->isOfType('Neos.Neos:Document') ? $node : $ancestors->first();

$siteNode = $ancestors->last();

but i dont know if its a criteria for the homepage node to be of type Neos.Neos:Document? see https://neos-project.slack.com/archives/C3MCBK6S2/p1694339628529459?thread_ts=1694269188.257739&channel=C3MCBK6S2&message_ts=1694339628.529459

---

the other approach using your findClosestNode and this hacky SiteNodeUtility::findSiteNode

neos-development-collection/Neos.Neos/Classes/Domain/Service/SiteNodeUtility.php

Lines 40 to 57 in d9c374a

	public function findSiteNode(Node $node): Node
	{
	$previousNode = null;
	$subgraph = $this->contentRepositoryRegistry->subgraphForNode($node);
	do {
	if ($node->nodeType->isOfType('Neos.Neos:Sites')) {
	// the Site node is the one one level underneath the "Sites" node.
	if (is_null($previousNode)) {
	break;
	}
	return $previousNode;
	}
	$previousNode = $node;
	} while ($node = $subgraph->findParentNode($node->nodeAggregateId));
	// no Site node found at rootline
	throw new \RuntimeException('No site node found!');
	}

$documentNode =  $subgraph->findClosestNode($node->nodeAggregateId, FindClosestNodeFilter::create(nodeTypeConstraints: 'Neos.Neos:Document');

$siteNode = $this->siteNodeUtility->findSiteNode($node);

---

i just remembered that Bernhard hat the plan to introduce a Neos.Neos:Site root site nodeType: #4531

this would allow to write a querys like:

$documentNode =  $subgraph->findClosestNode($node->nodeAggregateId, FindClosestNodeFilter::create(nodeTypeConstraints: 'Neos.Neos:Document');

$siteNode =  $subgraph->findClosestNode($node->nodeAggregateId, FindClosestNodeFilter::create(nodeTypeConstraints: 'Neos.Neos:Site');

which is imo as perfect as it gets?

[bwaidelich]

before merging this i would like to discuss how we want to ideally fetch all the necessary nodes for the fusion view

is that really related to this very PR?

the other approach using your findClosestNode and this hacky SiteNodeUtility::findSiteNode

Why is that hacky?

[skurfuerst]

Hey,

looked at the code, looks great to me.

@bwaidelich IMHO this can be merged. Great work :)

@mhsdesign I do not understand why you want to open up the use cases even more; IMHO these are separate topics.

All the best,
Sebastian

[mhsdesign]

yes no sorry all fine - that was just the thinking progress in my head ^^

i really like this and lets merge it!