FEATURE: Timeable Node Visibility

[dlubitz]

Re-Implements the already know feature for hiding and/or showing content nodes on a specific point on time.

What has changed in comparision to the old implementation:

• Check for exceeded date time is handled async in a background job (./flow timeablenodevisibility:execute)
• The background job creates proper events to trigger enabling or disabling of the content.
• No implicit hiding of nodes anymore. The configured hidden state is always respected by Neos. Just the background job changes the hidden state.
• No extra cache handling anymore. As the background job triggers the event to change the visibility, the cache flushing is also triggered the same way as all other content changes.
• The feature is now located in the Neos.TimableNodeVisibility package (neos/timeable-node-visibility) and not part of the Neos minimum installation anymore. So you are able to decide, if you want to enable this feature or not by adding it manually to your dependencies.

Renamed the properties:

• _hiddenBeforeDateTime => enableAfterDateTime
• _hiddenAfterDateTime => disableAfterDateTime

Resolves: #4759
Related: #4834 , neos/rector#42

[mhsdesign]

THANK you so much! I just had a quick look over the files (except the behavioural tests ^^)

[kitsunet]

Looks pretty cool, thanks for taking care! Left some comments, but I think this is nicely underway, I agree with concerns regarding performance but don't have amazing ideas right now, apart from, should/could this be a projection.

[mhsdesign]

Thanks for this feature. I just played around with a little and i can say that it works :D.

At first i had to update your branch a little and to ease installation i pushed a new temporary branch to neos so everyone can add this in their root composer json to experiment: (i actually have no clue how you got it running *g)

"neos/neos-development-collection": "dev-temp-head-90-timeable as 9.0"

A few things to be noted / discussed:

• we should add it to the slicer https://github.com/neos/slicer so this package its splatted. ✅
• And this package needs a readme saying this is a sub-split and i would propose also some additional docs on how to use it as people will need to install it separately. ✅
• also i thought we discussed that we wanted to make everything opt in, so that we wont provide an override nodetypes yaml
  • on the other hand this works as expected and requires 0 configuration so top ✅
• i noticed a problem that the useworkspace would not be marked outdated and rebased, and thus changes are actually not visible inside the ui (without a random rebase from somewhere)
  • this is NOT fixxable via flow workspace:rebaseoutdated and i had to directly write the commands without checking their state -> so maybe something bigger is wrong here? ✅
    See BUG: Running ./flow structureadjustments:fix doesn't mark workspaces as outdated #4508
• i understand that the live workspace is $special, but maybe we should allow this feature for all root workspaces, if not already? (Or maybe just for every workspace or does this lead to some obscure state? probably?) ✅ (not part of this pr)
• disabled vs hidden ui label: FEATURE: Timeable Node Visibility #4817 (comment) ✅ (can be changed later)

[dlubitz]

I prepared the split:
PR: neos/slicer#21
Repo: https://github.com/neos/timeable-node-visibility

[dlubitz]

Follow up:

• Register package on packagist