Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: Improve user experience for Dimension Switcher #3451

Merged
merged 12 commits into from
Apr 11, 2023
Merged

FEATURE: Improve user experience for Dimension Switcher #3451

merged 12 commits into from
Apr 11, 2023

Commits on Mar 30, 2023

  1. FEATURE: Extract DimensionSelector and render single dimentsion 

    This commit extracts the DimensionSelector to an own component. The component gets an additional property to render only the Select without any label.

The DimensionSwitcher now renders a single DimensionSelector if we have just one dimension and the old dropdown if we have multiple.
    @markusguenther
    markusguenther committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    2f22cee View commit details
    Browse the repository at this point in the history

  2. BUGFIX: Hide create new div when it is not permitted

    @markusguenther
    markusguenther committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    448ca3d View commit details
    Browse the repository at this point in the history

  3. BUGFIX: Resolve linting issues

    @markusguenther
    markusguenther committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    5c0ca4f View commit details
    Browse the repository at this point in the history

  4. TASK: Adjust acceptance tests

    @markusguenther
    markusguenther committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    73b78ef View commit details
    Browse the repository at this point in the history

  5. TASK: Render icon for single dimension

    @markusguenther
    markusguenther committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    1520d8c View commit details
    Browse the repository at this point in the history

  6. FEATURE: Introduce new props for SelectBox 

    This commit adds the headerIcon property for the SelectBox and the showIcon prop for the ListPreviewElement and SelectBox_Option_SingleLine.

With these new properties it is possible to render an icon only inside the header, even when the option has no icon definded.
    @markusguenther
    markusguenther committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    27cabbd View commit details
    Browse the repository at this point in the history

  7. TASK: Replace the custom icon with the new headerIcon prop

    @markusguenther
    markusguenther committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    06cb6a2 View commit details
    Browse the repository at this point in the history

  8. BUGFIX: Render headerIcon only for single dimension dropdown

    @markusguenther
    markusguenther committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    bc4ce47 View commit details
    Browse the repository at this point in the history

  9. TASK: Move list markup to DimensionSwitcher

    @markusguenther
    markusguenther committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    c3bd36a View commit details
    Browse the repository at this point in the history

  10. TASK: Simplify getDimensionIcon function

    @markusguenther
    markusguenther committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    4a9f390 View commit details
    Browse the repository at this point in the history

  11. TASK: Remove showIcon prop again

    @markusguenther
    markusguenther committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    c2e7f25 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2023

  1. TASK: Adjust spacings

    @markusguenther
    markusguenther committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    f3c21f1 View commit details
    Browse the repository at this point in the history