BUGFIX: Trim leading and tailing whitespaces #3860
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whitespaces like a tab can lead to a 404 error if a URL has been pasted to a LinkEditor or LinkInput. As datasources, assets, URLs and slugs should not start with a whitespace, we can remove them. Fixes: neos#3859
|
If I missed something, please let me know. Also thought about an editor option to trim that, but that would be more a feature than a bug fix then. trimed-link.mp4 |
Sebobo
reviewed
Sep 26, 2024
Ensure that searchTerm is a string before trimming the value.
|
The acceptance tests will run when #3855 has been merged. At the moment they are broken. |
Sebobo
approved these changes
Sep 26, 2024
|
Thanks for having a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whitespaces like a tab can lead to a 404 error if a URL has been pasted to a
LinkEditororLinkInput.As data sources, assets, URLs and slugs should not start with a whitespace, we can remove them.
Fixes: #3859